-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prerelease increment behavior #1303
feat: add prerelease increment behavior #1303
Conversation
5a13312
to
bbdaa52
Compare
bbdaa52
to
afe1c5d
Compare
c9c7d4f
to
6d31423
Compare
2e10c97
to
ff9ef6d
Compare
7ea9399
to
3b49259
Compare
Hi @neilime do you mind resolving the conflicts? |
3b49259
to
29e71e2
Compare
@jetersen done ! |
Hi @jetersen, any chance to review this PR, when you'll have time? Thanks |
426d7f3
to
0805bb0
Compare
cbce15f
to
7ffefa9
Compare
@neilime I think we are missing an update to action.yml 🤔 |
@jetersen Which omission are you referring to? |
instead of only inside |
Reason I ask I could foresee people wanting the flexibility to determine the prerelease idenfier based on data and scripts in a GitHub action 🤔 |
Yes sure, I'm on it |
Minor nit: the naming of |
I've added the pre-release-identifier input to our fork, leukeleu@e607143 feel free to cherry pick that commit. |
I concur we should attempt to be consistent here. |
7ffefa9
to
629b6cf
Compare
FYI I've based the name to be consistent with |
38f141e
to
831cdfc
Compare
@jetersen I've made a separate commit to handle naming of "prerelease-identifier" and input |
Allows to increment the prerelease number (https://semver.org/#spec-item-9).
It does NOT change ANY of the actual behavior
It introduces a new config variable or input "prerelease-identifier"
The prerelease number is increment ONLY when: